Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor sample improvements #62

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Minor sample improvements #62

merged 7 commits into from
Jun 3, 2024

Conversation

stonko1994
Copy link
Contributor

Changes

This PR aims to improve the example UI as well as code quality.

Changes:

  • Bring the UI to today's iOS standards (see screenshots below)
  • Remove the custom PosterImage handling (This is now handled by our SDK)
  • Remove the fullscreen showcase as there was no fullscreen handling implemented
  • Improve code style of the iOS and tvOS sample
  • Remove the CocoaPods references from the LaunchScreen
Old New
IMG_0042 IMG_0041

Checklist

  • I added an update to CHANGELOG.md file Not needed for only sample changes
  • I ran all the tests in the project and they succeed

@stonko1994 stonko1994 requested a review from rolandkakonyi May 28, 2024 13:13
Base automatically changed from feature/add-ads-to-the-tvOS-sample to develop May 28, 2024 13:13
@stonko1994 stonko1994 requested a review from rolandkakonyi May 29, 2024 14:14
@stonko1994 stonko1994 merged commit ced3a58 into develop Jun 3, 2024
1 check passed
@stonko1994 stonko1994 deleted the feature/minor-sample-improvements branch June 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandkakonyi rolandkakonyi rolandkakonyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stonko1994 @rolandkakonyi