Support additional device content tags in conviva integration #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigavehovec
changed the title
zigavehovec
force-pushed
the
PI-3398/support-additional-device-content-tags-in-conviva-integration
branch
from
e77f293 to
059bee6
Compare
stonko1994
reviewed
Jun 5, 2024
| @@ -85,6 +93,9 @@ class ContentMetadataBuilder: CustomStringConvertible { | |||
| if let custom = self.custom { | |||
| contentInfo.merge(custom) { $1 } | |||
| } | |||
| if let additionalStandardTags = self.additionalStandardTags { | |||
There was a problem hiding this comment.
Note: (no action required)
Since Swift 5.7 you could write this like this:
Suggested change
| if let additionalStandardTags = self.additionalStandardTags { | |
| if let additionalStandardTags { |
However, the Swift version specified in the podspec file is set to 5.0. We could update it since it's quite old already (we are on 5.10 no in the Player SDK) Not relevant for this PR.
There was a problem hiding this comment.
Ah cool, didn't know about that Swift feature 👍
Co-authored-by: David Steinacher <david.steinacher@bitmovin.com>
Co-authored-by: David Steinacher <david.steinacher@bitmovin.com>
stonko1994
approved these changes
Jun 6, 2024
zigavehovec
deleted the
PI-3398/support-additional-device-content-tags-in-conviva-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Conviva has a list of predefined standard device and content tags that this integration currently doesn't support reporting.
Solution
MetadataOverrides.additionalStandardTagsthat allows to set additional standard tags for the session.Notes
Android integration PR: bitmovin/bitmovin-player-android-analytics-conviva#56
Checklist
CHANGELOG.mdfile