Ad lifecycle reporting #68
Conversation
| ) | ||
| } | ||
|
|
||
| func onAdFinished() { | ||
| videoAnalytics.reportAdBreakEnded() | ||
| adAnalytics.reportAdEnded() |
There was a problem hiding this comment.
This change is a behaviour change of the integration!!! (and of course the related changes i.e. moving the orignal call into the ad break finished event, and the starting calls in the ad started and ad break started)
| @@ -383,6 +387,26 @@ public final class ConvivaAnalytics: NSObject { | |||
| } | |||
| } | |||
|
|
|||
| private extension Ad { | |||
| var adInfo: [String: Any] { | |||
There was a problem hiding this comment.
Will be extended in a follow up PR.
| } | ||
|
|
||
| func onAdBreakFinished(_ event: AdBreakFinishedEvent) { | ||
| customEvent(event: event) | ||
| videoAnalytics.reportAdBreakEnded() | ||
| } | ||
|
|
||
| func onDestroy() { |
There was a problem hiding this comment.
I can't comment on internalEndSession():
Should we also end the adAnalytics in there? See this change on the web integration.
There was a problem hiding this comment.
I am not sure. I couldn't find anything in that regard in the documentation.
I also looked at another integration, and this is not done there.
There was a problem hiding this comment.
As discussed offline: Reporting an ended or skipped doesn't really represent the reality. Further, the video analytics and the ad analytics are coupled either way. So reporting a session ended on the video analytics implies that everything else is ended as well.
We will not add preemptive "cleanup".
Sidenote: We tested the reporting anyways, but it does not show up in the dashboard anyway.
Problem
Ad tracking is done using custom events, instead of the conviva provided ad analytics.
Solution
Notes
Finer grained tracking is implemented in follow up PRs. (To keep PR sizes smaller, or at least the production code changes)
Checklist
CHANGELOG.mdfile