Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CISAdAnalyticsTestDouble #69

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Implement CISAdAnalyticsTestDouble #69

merged 6 commits into from
Jun 5, 2024

Conversation

matamegger
Copy link
Contributor

Problem

The test double is not implemented/ready to be used for testing.

Solution

Implement most of the functions to report data for spy.

Notes

Checklist

  • I added an update to CHANGELOG.md file
  • I ran all the tests in the project and they succeed

@matamegger matamegger marked this pull request as ready for review June 5, 2024 06:27
@matamegger matamegger requested a review from stonko1994 June 5, 2024 06:27
stonko1994
stonko1994 reviewed Jun 5, 2024
View reviewed changes
@matamegger matamegger requested a review from stonko1994 June 5, 2024 11:14
@matamegger matamegger merged commit 31ee405 into develop Jun 5, 2024
2 of 3 checks passed
@matamegger matamegger deleted the implement_ad_analytics_double branch June 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonko1994 stonko1994 stonko1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matamegger @stonko1994