Improve SwiftLint setup #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SwiftLint config file (
.swiftlint.yml) was placed in the./Examplefolder and was not respected properly when running SwiftLint.Solution
Moving the
.swiftlint.ymlfile to the project root so it is properly respected. This change also includes migrating SwiftLint from CocoaPods to Mint (to be able to execute it directly from the root folder).To keep the Xcode compatibility, the SwiftLint command was changed to
(cd ${SRCROOT}/.. && "./scripts/run_swiftlint.sh" -xcode -path .). This also executes SwiftLint form the project root folder instead of the Example folder.Checklist
CHANGELOG.mdfile Already exists