Fix imaVersionString property name
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
commented
Jul 1, 2024
| @@ -68,8 +68,7 @@ class ViewController: UIViewController { | |||
| metadata.custom = ["custom_tag": "Episode"] | |||
| metadata.additionalStandardTags = ["c3.cm.contentType": "VOD"] | |||
|
|
|||
| metadata.imaSdkVerison = Bundle(for: IMAAdsManager.self) | |||
| .infoDictionary?["CFBundleShortVersionString"] as? String | |||
| metadata.imaSdkVersion = IMAAdsLoader.sdkVersion() | |||
There was a problem hiding this comment.
FYI the IMA SDK has a dedicated method to get the version.
matamegger
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a typo in
MetadataOverrides.imaSdkVerison, this PR fixes it.Solution
Added a new property called
imaSdkVersionand deprecatedimaSdkVerisonwith getting and setting its value to the new property.Notes
Also improved the IMA version detection in the Example application.
Checklist
CHANGELOG.mdfile