Fix invalid session ID in post roll ad sessions #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rolandkakonyi
commented
Jul 24, 2024
Comment on lines
621
to
622
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.10) { [weak self] in | ||
| guard let self else { return } |
There was a problem hiding this comment.
sneak: fixed missing weak reference
rolandkakonyi
commented
Jul 24, 2024
| @@ -33,8 +33,8 @@ extension BitmovinPlayerListener: PlayerListener { | |||
| // The default SDK error handling is that it triggers the onSourceUnloaded before the onError event. | |||
| // To track errors to conviva we need to delay the onSourceUnloaded to ensure the onError event is | |||
| // called first. | |||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) { | |||
| self.delegate?.onSourceUnloaded() | |||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) { [weak self] in | |||
There was a problem hiding this comment.
sneak: fixed missing weak reference
rolandkakonyi
commented
Jul 24, 2024
Comment on lines
-148
to
-155
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.10) { | ||
| expect(spy).notTo( | ||
| haveBeenCalled( | ||
| withArgs: [ | ||
| CIS_SSDK_PLAYBACK_METRIC_PLAYER_STATE: "\(PlayerState.CONVIVA_BUFFERING.rawValue)" | ||
| ] | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I replaced this pattern overall in this file to wrap it with waitUntil as there was no guarantee that the current test is still running when the asyncAfter executes the expect.
stonko1994
approved these changes
Jul 24, 2024
| self.internalEndSession() | ||
| } | ||
| self.playbackFinishedDispatchWorkItem = playbackFinishedDispatchWorkItem | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.10, execute: playbackFinishedDispatchWorkItem) |
There was a problem hiding this comment.
Nit:
Suggested change
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.10, execute: playbackFinishedDispatchWorkItem) | |
| DispatchQueue.main.asyncAfter(deadline: .now() + .milliseconds(100), execute: playbackFinishedDispatchWorkItem) |
or
Suggested change
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.10, execute: playbackFinishedDispatchWorkItem) | |
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.1, execute: playbackFinishedDispatchWorkItem) |
There was a problem hiding this comment.
fixed in 865222d
Base automatically changed from
feature/fix-analytics-video-data-auto-collecting
to
develop
July 24, 2024 11:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When playing a post-roll ad, "invalid session ID" error shows up on Conviva Touchstone.
Solution
Postponing ending the session from
onPlaybackFinishedevent with a delay of0.1sto check if there is anonAdBreakStartedevent is received and then only end the session onceonAdBreakFinishedevent is seen fixes the problem.Notes
Both CSAI and SSAI ad integration were adjusted to address the problem overall.
Checklist
CHANGELOG.mdfile - already added in Fix analytics video data auto collection #81