Skip to content

Commit

Permalink
Merge pull request #685 from bitmovin/feature/fontcolor-comcast-stbs
Browse files Browse the repository at this point in the history
Subtitle font color customization not working on Comcast STBs
  • Loading branch information
dweinber authored Feb 20, 2025
2 parents e1b6aa4 + b1d09a4 commit c6f8bed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## Fixed
- Setting font color in subtitle customization settings not working on Comcast X1 Set-Top Boxes and other older WebKit-based platforms

## [3.86.0] - 2025-02-20

### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
&.#{$prefix}-fontcolor-#{$color-name}#{$opacity-name} {
.#{$prefix}-ui-subtitle-label {
color: transparentize($color-value, 1 - $opacity-value);

Check warning on line 47 in src/scss/skin-modern/components/subtitlesettings/_subtitleoverlay-settings.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Expected `-WebKit-text-fill-color`, found `color`
-WebKit-text-fill-color: transparentize($color-value, 1 - $opacity-value);
}
}
}
Expand Down

0 comments on commit c6f8bed

Please sign in to comment.