Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github actions to v4 #686

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Upgrade github actions to v4 #686

merged 1 commit into from
Feb 20, 2025

Conversation

wasp898
Copy link
Contributor

@wasp898 wasp898 commented Feb 20, 2025

Description

Fixes build error:

This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`.

Checklist (for PR submitter and reviewers)

  • [/] CHANGELOG entry not needed

@wasp898 wasp898 self-assigned this Feb 20, 2025
@wasp898
Copy link
Contributor Author

wasp898 commented Feb 20, 2025 •
edited
Loading

Build failed on base branch before these changes. See: https://github.com/bitmovin/bitmovin-player-ui/actions/runs/13435541346
Works now 👍

felix-hoc
felix-hoc requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@felix-hoc felix-hoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry, otherwise the release action will fail.

@wasp898
Copy link
Contributor Author

wasp898 commented Feb 20, 2025

Please add a changelog entry, otherwise the release action will fail.

There's nothing to release though.

@wasp898 wasp898 requested a review from felix-hoc February 20, 2025 12:54
felix-hoc
felix-hoc approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@felix-hoc felix-hoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

@wasp898 wasp898 merged commit fc0181c into develop Feb 20, 2025
3 checks passed
@wasp898 wasp898 deleted the feature/update-github-actions branch February 20, 2025 12:59
@wasp898 wasp898 mentioned this pull request Feb 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-hoc felix-hoc felix-hoc approved these changes

Assignees

@wasp898 wasp898

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasp898 @felix-hoc