fix: show field name in error message when base64 decoding fails #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alemorcuq
suggested changes
May 9, 2024
| } | ||
|
|
||
| if !strings.Contains(err.Error(), "foo") { | ||
| t.Errorf("Unseal error did not contain field name %q: %v", "foo", err) |
There was a problem hiding this comment.
For consistency with the other tests:
Suggested change
| t.Errorf("Unseal error did not contain field name %q: %v", "foo", err) | |
| t.Errorf("Expecting error: %v to contain field %q", err, "foo") |
|
|
||
| _, err := sealedSecret.Unseal(codecs, keys) | ||
| if err == nil { | ||
| t.Fatalf("Unseal did not return expected error: %v", err) |
There was a problem hiding this comment.
For consistency with the other tests:
Suggested change
| t.Fatalf("Unseal did not return expected error: %v", err) | |
| t.Fatalf("Expecting error: got nil instead") |
Signed-off-by: Maximilian Gaß <m.gass@babiel.com>
mxey
force-pushed
the
base64-error-field-name
branch
from
6227b53
to
f742928
Compare
alemorcuq
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
unsealing errors usually show the field name that caused the error - except for base64 decoding. This change fixes that.
Benefits
clearer error message
Possible drawbacks
none
Applicable issues
Additional information