[helm] Set GOMAXPROCS and GOMEMLIMIT environment variables
#1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnoordsij
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
jnoordsij
force-pushed
the
set-gomemlimit-gomaxprocs
branch
from
c65ed75 to
93b96dd
Compare
…r resources Signed-off-by: Jesper Noordsij <jesper.noordsij@gmail.com>
Signed-off-by: Jesper Noordsij <jesper.noordsij@gmail.com>
jnoordsij
force-pushed
the
set-gomemlimit-gomaxprocs
branch
from
93b96dd to
4db0bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Set
GOMAXPROCSandGOMEMLIMITenvironment variables based on container resources.Inspired by traefik/traefik-helm-chart#1029.
Benefits
This should reduce potential CPU throttling and OOMKills on containers.
Possible drawbacks
This creates an empty
envkey for those not setting resource values. This is only a little ugly, but should not be harmful. Alternatively, we could add some conditional wrapper around the wholeenvblock to only make it appear if a value is set, but that will be more complicated if additional env would be added in the future.Applicable issues
N/A
Additional information
The
resourceFieldRefis a very specific Kubernetes directive that is created specifically for passing resource-related values, which rounds up the CPU value to the nearest whole number (e.g. 250m to 1) and passes the memory as a numeric value; so64Miwould result in the environment variable being set to67108864. This by design makes it completely compatible with Go's API.An example is documented within Kubernetes documentation itself: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#use-container-fields-as-values-for-environment-variables.