Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/bncert] Add support for IPv6 #17

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[bitnami/bncert] Add support for IPv6 #17

merged 1 commit into from
Mar 6, 2024

Conversation

gongomgra
Copy link
Collaborator

Description of the change

Adds support for IPv6-based domains. Due to some limitations in the InstallBuilder tool, we have removed the IP and DNS validations, which were duplicated with the lego tool internal actions. We simply relay on the lego tool checks now.

Benefits

IPv6 support.

Possible drawbacks

Not expected

Signed-off-by: Gonzalo Gomez Gracia <gonzalog@vmware.com>
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongomgra gongomgra merged commit a681e4e into main Mar 6, 2024
13 checks passed
@github-actions github-actions bot added the solved label Mar 6, 2024
@carrodher carrodher deleted the feature/ipv6 branch May 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants