-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] Inclusion of namespace: {{ .Release.Namespace }}
in objects metadata
#2006
Comments
Hi @glothriel Thanks so much for the feedback I don't see any advantage on adding the namespace to the manifests since
$ helm template --namespace XXX grafana bitnami/grafana | kubectly apply -
$ helm template grafana bitnami/grafana | kubectly apply --namespace XXX - Honestly I don't see any advantage on using "approach A" vs "approach B"
I understand people was using |
Theoretically yes, but chart values are the problem here. We generate values from our internal GUI configuration tool. Those values contain secrets, that we don't want to expose anywhere. Our deployment pipeline runs helm template outside of the cluster then uses sealed secrets to encrypt the secrets and pushes everything to git.
It seems, that Spinnaker also takes similar approach, at least they suggest including the |
Hi @glothriel I see the point on using a fully declarative, namespaced definition of all your kubernetes resources. And it's great you're using sealed secrets by the way. @javsalgar what's you opinion on this? As a workaround you could use kustomize to adapt the manifests you generate with |
Hi @juan131 We are currently blocked, so we would really appreciate a decision here. There is another helm chart we'd like to use (RabbitMQ) but lack of |
I'm not sure if I fully understood, but it seems that adding the namespace increases the compatibility with other tools like Spinnaker or other GUI-based tools. Then I see no harm in adding the feature. |
Thanks for the decision guys, from my perspective this ticket can now be closed, as I already know what I wanted to know. |
Thank you for the great reasons you gave us to include these changes! Let's close the issue Please do not hesitate to reopen it if you face issues again with the "namespace" in your manifests. |
* [bitnami/consul] Introduced .Release.Namespace in objects meta This PR implements #2006 for consul chart * [bitnami/consul] Update components versions Signed-off-by: Bitnami Containers <containers@bitnami.com> Co-authored-by: Bitnami Containers <containers@bitnami.com>
Which chart:
prometheus-operator, grafana, but applies to all the charts
Description
In the face of charts/stable deprecation, we are investigating other methods of deploying prometheus-operator and grafana using helm.
In our specific case, we are using
helm template
to render templates that fully describe our cluster's state in a declarative way, and then we load them to kubernetes using kubectl apply, in a GitOps fashion.In order for this to work, we need to include information about namespace inside the templates.
One way to do this, is by including
In all namespace-scoped resource definitions. Bitnami charts lack this behavior.
My question is: would you accept PR with this functionality added? It seems that there is no consensus in helm community about how should this be handled, at the moment at least.
The text was updated successfully, but these errors were encountered: