Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/ejbca] Fix EJBCA Cypress Test #13465

Closed
wants to merge 1 commit into from

Conversation

mdhont
Copy link
Contributor

@mdhont mdhont commented Nov 10, 2022

Signed-off-by: Michiel michield@vmware.com

Description of the change

Currently the EJBCA Cypress test is unstable. The p12 is not always downloaded due to a bug in Cypress. A workaround for this bug is to avoid checking for the file, and continue with the test after a few seconds. As the test later checks if the certificate exists, we can safely assume it has been possible to create a certificate.

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

Signed-off-by: Michiel <michield@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Nov 10, 2022
Copy link
Contributor

@aoterolorenzo aoterolorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward if there's a subsequent test point already checking the cert directly or indirectly. LGTM

@github-actions
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Nov 30, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Dec 5, 2022
@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Dec 5, 2022
@bitnami-bot bitnami-bot closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants