[bitnami/redis] Allow option to disable hostnames usage when configuring nodes #14599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing nodes Signed-off-by: jotamartos <jotamartos@vmware.com>
aoterolorenzo
previously approved these changes
Jan 31, 2023
javsalgar
previously approved these changes
Feb 2, 2023
carrodher
reviewed
Feb 2, 2023
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Juan José Martos <jotamartos@gmail.com>
jotamartos
dismissed stale reviews from javsalgar, fmulero, and aoterolorenzo
via
b3bc274
fmulero
approved these changes
Feb 2, 2023
carrodher
approved these changes
Feb 2, 2023
nik0811
pushed a commit
to nik0811/charts
that referenced
this pull request
Feb 4, 2023
…ing nodes (bitnami#14599) * [bitnami/redis] Allow option to disable hostnames usage when configuring nodes Signed-off-by: jotamartos <jotamartos@vmware.com> * Remove empty line Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Juan José Martos <jotamartos@gmail.com> --------- Signed-off-by: jotamartos <jotamartos@vmware.com> Signed-off-by: Juan José Martos <jotamartos@gmail.com> Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: nikhil <nikhil811raj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jotamartos jotamartos@vmware.com
Description of the change
This change allows you use IPs instead of hostnames when configuring the different nodes in the deployment
Benefits
This solves the tilt mode issue reported here
Possible drawbacks
None from the tests I performed
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm