[bitnami/thanos] Fine-granted checksum calculation for deployment re-trigger #24014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trigger Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
carrodher
added
verify
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
djjudas21
pushed a commit
to djjudas21/bitnami-charts
that referenced
this pull request
Apr 17, 2024
…trigger (bitnami#24014) Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Miguel Ruiz <miruiz@vmware.com> Co-authored-by: Miguel Ruiz <miruiz@vmware.com> Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR changes the the input of the config checksum which triggers the reload.
The whole configmaps and secrets are included as checksum input. The configmap and secrets contains labels which includes the helm chart version. Each new helm chart version forces a pod restart which is not always necessary.
The PR extracts the config to template helper. which can be used as input for the checksum.
Benefits
Avoid unnecessary pod restart on each helm chart version. This can be cause a lot of trouble on upgrade paths, where the helm chart version was bumped, but there was no need for an restart.
Possible drawbacks
N/A
Applicable issues
Additional information
serviceAccount.automountServiceAccountTokenand documentautomountServiceAccountTokengrafana/helm-charts#2997Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm