Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] feat!: 🔒 💥 Improve security defaults #24171

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

javsalgar
Copy link
Contributor

@javsalgar javsalgar commented Mar 5, 2024

BREAKING CHANGE

Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com

Description of the change

This major bump changes the following security defaults:

  • runAsGroup is changed from 0 to 1001
  • readOnlyRootFilesystem is set to true
  • resourcesPreset is changed from none to the minimum size working in our test suites (NOTE: resourcesPreset is not meant for production usage, but resources adapted to your use case).
  • global.compatibility.openshift.adaptSecurityContext is changed from disabled to auto.

Benefits

  • Better compliance with NSA and MITRE security checklists
  • Improved compatibility with Openshift

Possible drawbacks

This could potentially break any customization or init scripts used in your deployment. If this is the case, change the default values to the previous ones.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Mar 5, 2024
@github-actions github-actions bot requested a review from juan131 March 5, 2024 15:46
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
juan131
juan131 previously approved these changes Mar 6, 2024
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
juan131
juan131 previously approved these changes Mar 7, 2024
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
juan131
juan131 previously approved these changes Mar 18, 2024
Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
@javsalgar javsalgar merged commit 3911a57 into main Mar 18, 2024
10 checks passed
@javsalgar javsalgar deleted the feature/postgresql-security-major branch March 18, 2024 15:47
djjudas21 pushed a commit to djjudas21/bitnami-charts that referenced this pull request Apr 17, 2024
)

* [bitnami/postgresql] feat!: 🔒 💥 Improve security defaults

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>

* docs: 📝 Add upgrading notes

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>

* docs: 🚨 Fix incorrect indentation

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>

* fix: ⏪ Return runAsGroup in volumePermissions

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>

* chore: ⬆️ Bump common subchart

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>

---------

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
maybeanerd added a commit to maybeanerd/home-cluster that referenced this pull request Aug 19, 2024
with v15 of the chart, some security defaults were changed. This reverts them to see if it will fix the deployment.
bitnami/charts#24171

We could go and change some of them to be the new values once it works, to see what ends up breaking it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami postgresql solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants