-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/consul] Updated consul chart to address empty dir missing for consul data #25023
Conversation
Signed-off-by: Evan Stork <estork@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @EStork09 for your contribution
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EStork09 Could you fix the conflicts? We are not able to do it.
Signed-off-by: Evan Stork <estork@live.com>
Signed-off-by: Evan Stork <estork@live.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r consul data (bitnami#25023) * Updated consul chart to address empty dir Signed-off-by: Evan Stork <estork@live.com> * Added emptry dir to work with read only file system Signed-off-by: Evan Stork <estork@live.com> * Updated for read only Signed-off-by: Evan Stork <estork@live.com> --------- Signed-off-by: Evan Stork <estork@live.com> Signed-off-by: Fran Mulero <fmulero@vmware.com> Co-authored-by: Fran Mulero <fmulero@vmware.com> Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Description of the change
Adding empty dir for the consul data storage
Benefits
This allows the container to run as read only file system while storing the consul data in the empty dir
Possible drawbacks
Empty dir growing too large, but in that case just run with storage volume.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm