Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/consul] Updated consul chart to address empty dir missing for consul data #25023

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

EStork09
Copy link
Contributor

@EStork09 EStork09 commented Apr 6, 2024

Description of the change

Adding empty dir for the consul data storage

Benefits

This allows the container to run as read only file system while storing the consul data in the empty dir

Possible drawbacks

Empty dir growing too large, but in that case just run with storage volume.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added consul triage Triage is needed labels Apr 6, 2024
@github-actions github-actions bot requested a review from carrodher April 6, 2024 20:59
Signed-off-by: Evan Stork <estork@live.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 8, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 8, 2024
@github-actions github-actions bot removed the request for review from carrodher April 8, 2024 20:41
@github-actions github-actions bot requested a review from fmulero April 8, 2024 20:41
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @EStork09 for your contribution

LGTM

Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @EStork09.

Version 11.0.4 was already released #25039. Could you update your code?

Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EStork09 Could you fix the conflicts? We are not able to do it.

EStork09 and others added 3 commits April 13, 2024 03:20
Signed-off-by: Evan Stork <estork@live.com>
Signed-off-by: Evan Stork <estork@live.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmulero fmulero enabled auto-merge (squash) April 15, 2024 09:41
@fmulero fmulero merged commit d21f127 into bitnami:main Apr 16, 2024
8 checks passed
djjudas21 pushed a commit to djjudas21/bitnami-charts that referenced this pull request Apr 17, 2024
…r consul data (bitnami#25023)

* Updated consul chart to address empty dir

Signed-off-by: Evan Stork <estork@live.com>

* Added emptry dir to work with read only file system

Signed-off-by: Evan Stork <estork@live.com>

* Updated for read only

Signed-off-by: Evan Stork <estork@live.com>

---------

Signed-off-by: Evan Stork <estork@live.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Co-authored-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consul solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/consul] New Consul Chart readonly file system breaks consul without persistence
3 participants