-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/nginx] Allowing for customize dnsPolicy and dnsConfig for nginx #26619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sepauli <sebastian.pauli@protonmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
carrodher
added
verify
Execute verification workflow for these changes
in-progress
labels
Jun 4, 2024
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
reviewed
Jun 5, 2024
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
approved these changes
Jun 11, 2024
longnbao
pushed a commit
to longnbao/bitnami-helm-charts
that referenced
this pull request
Jun 12, 2024
…inx (bitnami#26619) * Allowing for customize dnsPolicy and dnsConfig for nginx Signed-off-by: sepauli <sebastian.pauli@protonmail.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update bitnami/nginx/Chart.yaml Signed-off-by: Juan José Martos <jotamartos@gmail.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> --------- Signed-off-by: sepauli <sebastian.pauli@protonmail.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Juan José Martos <jotamartos@gmail.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Co-authored-by: Juan José Martos <jotamartos@gmail.com> Signed-off-by: Long Bao <long.nguyen.bao@trustingsocial.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds options to configure dnsPolicy and dnsConfig for the nginx chart.
Benefits
It would allow users to fine-grain their DNS resolution process, especially useful in an intranet environment.
This is an example:
Possible drawbacks
N/A
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm