Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/nginx] Allowing for customize dnsPolicy and dnsConfig for nginx #26619

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

sepauli
Copy link
Contributor

@sepauli sepauli commented Jun 4, 2024

Description of the change

This PR adds options to configure dnsPolicy and dnsConfig for the nginx chart.

Benefits

It would allow users to fine-grain their DNS resolution process, especially useful in an intranet environment.
This is an example:

dnsPolicy: "None"
dnsConfig:
  nameservers:
    - 192.0.2.1 # this is an example
  searches:
    - ns1.svc.cluster-domain.example
    - my.dns.search.suffix
  options:
    - name: ndots
      value: "2"
    - name: edns0
/usr/bin/helm template -f settings.yaml ./nginx | grep dnsPolicy -A 10                                                                              ✔ 
      dnsPolicy: None
      dnsConfig:
        nameservers:
        - 192.0.2.1
        options:
        - name: ndots
          value: "2"
        - name: edns0
        searches:
        - ns1.svc.cluster-domain.example
        - my.dns.search.suffix

Possible drawbacks

N/A

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: sepauli <sebastian.pauli@protonmail.com>
@github-actions github-actions bot added nginx triage Triage is needed labels Jun 4, 2024
@github-actions github-actions bot requested a review from carrodher June 4, 2024 07:08
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 4, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 4, 2024
@github-actions github-actions bot removed the request for review from carrodher June 4, 2024 08:38
@github-actions github-actions bot requested a review from jotamartos June 4, 2024 08:38
carrodher and others added 2 commits June 4, 2024 12:05
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
bitnami/nginx/Chart.yaml Outdated Show resolved Hide resolved
jotamartos and others added 2 commits June 5, 2024 17:03
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@jotamartos jotamartos enabled auto-merge (squash) June 5, 2024 15:09
jotamartos and others added 2 commits June 11, 2024 11:26
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@jotamartos jotamartos merged commit d7f4af3 into bitnami:main Jun 11, 2024
8 checks passed
longnbao pushed a commit to longnbao/bitnami-helm-charts that referenced this pull request Jun 12, 2024
…inx (bitnami#26619)

* Allowing for customize dnsPolicy and dnsConfig for nginx

Signed-off-by: sepauli <sebastian.pauli@protonmail.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update bitnami/nginx/Chart.yaml

Signed-off-by: Juan José Martos <jotamartos@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: sepauli <sebastian.pauli@protonmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Co-authored-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: Long Bao <long.nguyen.bao@trustingsocial.com>
@sepauli sepauli deleted the dns-service branch June 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nginx solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/nginx] Allowing for customize dnsPolicy and dnsConfig for nginx
4 participants