-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/apisix] Fixes to support running Apisix in standalone mode #27062
[bitnami/apisix] Fixes to support running Apisix in standalone mode #27062
Conversation
Signed-off-by: James Riley McHugh <mchugh_james@bah.com>
Signed-off-by: James Riley McHugh <mchugh_james@bah.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM but please undo the change I mentioned in my comment
…dalone-mode # Conflicts: # bitnami/apisix/CHANGELOG.md # bitnami/apisix/Chart.lock
Signed-off-by: James Riley McHugh <mchugh_james@bah.com>
Hello @jotamartos. I fixed the merge conflicts and responded to your request. Please let me know if there is anything additional needed. |
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
…dalone-mode # Conflicts: # bitnami/apisix/CHANGELOG.md # bitnami/apisix/Chart.lock
Signed-off-by: James Riley McHugh <mchugh_james@bah.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Sorry for the delay here. I added more information about why the symlink is lost. Would you mind updating the logic and the PR so everyone can benefit from the change? Thanks |
As a final note, the symlink is lost because we are mounting an empty volume to follow best security practices. There are many references to /usr/local/apisix in the code so we will keep the suggested changes and revisit the symlink configuration in the future. |
@jotamartos Thank you for reviewing and approving my PR! |
Please provide the timeline on when the next release of apisix will happen from bitnami with this standalone deployment fix? |
The new version was released right after the PR was merged, see https://hub.docker.com/layers/bitnamicharts/apisix/3.2.5/images/sha256-b52d44638bc1cc71ff9656a4073fe3878d955ef5f2c087e57a41c439157e1e55?context=explore |
Description of the change
Updates the
_helpers.tpl
file to disable the addition of control-plane environment variables to theapisix.renderConfInitContainer
andapisix.prepareApisixInitContainer
templates when the control plane is disabled. As these environment variables are sourced from secrets, they cause the init containers to fail if the secrets do not exist.Updates the
defaultConfig
in the Values.yaml so the etcd configs are removed if etcd is disabled and no external etcd servers are set.Updates the standalone instructions in the README.md to include the disabling of the dashboard, adding the
#END
line to the end of the example config, and updating the config path to be mounted at the path Apisix expects the config file to be at (/usr/local/apisix/conf/apisix.yaml
).Benefits
Apisix standalone mode should now work when following the instructions in the README.
Possible drawbacks
Unexpected impacts to other deployment modes. The changes are pretty minor though, and should have minimal risk of impacting other modes.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm