-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/milvus] feat: config external S3 tls client certs settings (… #27068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenraoCR
force-pushed
the
feat/bitnami/milvus/26111
branch
2 times, most recently
from
June 10, 2024 07:51
e06de25
to
52e8c55
Compare
this feature is just like #26110, please check and approve |
javsalgar
added
verify
Execute verification workflow for these changes
in-progress
labels
Jun 10, 2024
chenraoCR
force-pushed
the
feat/bitnami/milvus/26111
branch
from
June 17, 2024 06:37
5edd539
to
2d3dab3
Compare
…itnami#26111) Signed-off-by: Chen Rao <chenrao317328@163.com>
chenraoCR
force-pushed
the
feat/bitnami/milvus/26111
branch
from
June 18, 2024 01:48
8eb833f
to
29c8079
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Can you take a look at my new comment? I didn't notice that in the first review. Thanks
Signed-off-by: Chen Rao <chenrao317328@163.com>
Signed-off-by: Chen Rao <45187622+chenraoCR@users.noreply.github.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
config externalS3 tls settings
Benefits
allow users to config minio tls client certs when connect external minio running with tls
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm