Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] Custom SANs for auto-generated TLS certificates #27092

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

xdom
Copy link
Contributor

@xdom xdom commented Jun 11, 2024

Description of the change

Allows bitnami/kafka chart users to provide custom additional subject alternative names (SANs) for auto-generated TLS certificates using a tls.customAltNames value.

When external access is enabled (externalAccess.enabled) and service domains are filled (externalAccess.broker.service.domain, externalAccess.controller.service.domain), they are included in SANs, too.

Benefits

Auto-generated TLS certificates will work with domains configured for external access, and any other custom alternative names. Therefore, clients won't be forced to manually generate certificates for their PoC clusters, and won't have to disable hostname verification in clients when connecting via an external domain.

Possible drawbacks

Existing behavior changes, i.e. external access domain names were not previously added into the certificate SANs. This might be unwanted for some users. However, existing clusters will not be affected when using helm upgrade because the chart does not overwrite a TLS secret once it exists.

Applicable issues

N/A

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

xdom added 3 commits June 11, 2024 13:18
Signed-off-by: Dominik Matta <10259492+xdom@users.noreply.github.com>
Signed-off-by: Dominik Matta <10259492+xdom@users.noreply.github.com>
Signed-off-by: Dominik Matta <10259492+xdom@users.noreply.github.com>
@github-actions github-actions bot added kafka triage Triage is needed labels Jun 11, 2024
@github-actions github-actions bot requested a review from javsalgar June 11, 2024 11:51
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Jun 12, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 12, 2024
@github-actions github-actions bot removed the request for review from javsalgar June 12, 2024 07:58
@github-actions github-actions bot requested a review from juan131 June 12, 2024 07:58
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this enhancement! LGTM

@juan131 juan131 merged commit 45409ff into bitnami:main Jun 12, 2024
9 checks passed
longnbao pushed a commit to longnbao/bitnami-helm-charts that referenced this pull request Jun 12, 2024
…ami#27092)

Signed-off-by: Long Bao <long.nguyen.bao@trustingsocial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kafka solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants