[bitnami/kafka] Custom SANs for auto-generated TLS certificates #27092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allows bitnami/kafka chart users to provide custom additional subject alternative names (SANs) for auto-generated TLS certificates using a
tls.customAltNames
value.When external access is enabled (
externalAccess.enabled
) and service domains are filled (externalAccess.broker.service.domain
,externalAccess.controller.service.domain
), they are included in SANs, too.Benefits
Auto-generated TLS certificates will work with domains configured for external access, and any other custom alternative names. Therefore, clients won't be forced to manually generate certificates for their PoC clusters, and won't have to disable hostname verification in clients when connecting via an external domain.
Possible drawbacks
Existing behavior changes, i.e. external access domain names were not previously added into the certificate SANs. This might be unwanted for some users. However, existing clusters will not be affected when using
helm upgrade
because the chart does not overwrite a TLS secret once it exists.Applicable issues
N/A
Additional information
N/A
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm