Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/common] chore: 🔧 Relax large and xlarge presets resource requests #27312

Merged
merged 3 commits into from
Jun 17, 2024
Merged

[bitnami/common] chore: 🔧 Relax large and xlarge presets resource requests #27312

merged 3 commits into from
Jun 17, 2024

Conversation

javsalgar
Copy link
Contributor

Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com

Description of the change

This PR relaxes the xlarge and 2xlarge resources requests to acommodate the testing of big Java applications like Dremio.

NOTE: resourcesPreset is not meant for production so the change should not be considered breaking.

Benefits

Better testing of some solutions.

Possible drawbacks

n/a

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@javsalgar
[bitnami/common] chore: 🔧 Relax large and xlarge presets resource req…
fab28b6 
…uests

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 17, 2024
@github-actions github-actions bot requested a review from fmulero June 17, 2024 16:10
@bitnami-bot
Update CHANGELOG.md
b26fd01 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
fmulero
fmulero reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javsalgar

I've just left a little comment

bitnami/common/templates/_resources.tpl Outdated Show resolved Hide resolved
bitnami/common/templates/_resources.tpl Outdated Show resolved Hide resolved
@javsalgar
chore: ✏️ Set cerrect memory size
bbfd273 
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
fmulero
fmulero approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javsalgar javsalgar enabled auto-merge (squash) June 17, 2024 16:18
@javsalgar javsalgar disabled auto-merge June 17, 2024 16:18
@javsalgar javsalgar enabled auto-merge (squash) June 17, 2024 16:19
@javsalgar javsalgar merged commit 6ca69f6 into main Jun 17, 2024
8 checks passed
@javsalgar javsalgar deleted the feature/common-relax-requests-2 branch June 17, 2024 16:21
@mitchnielsen mitchnielsen mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

Assignees

@fmulero fmulero

Labels
bitnami common solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javsalgar @fmulero @bitnami-bot