Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/drupal] templates/ingress.yaml: fix wrong www.www tls name #29564

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

EnDjeee
Copy link
Contributor

@EnDjeee EnDjeee commented Sep 22, 2024

Description of the change

This should fix the issue mentioned in #29190, which impacts the nginx, wordpress and drupal charts.

Benefits

It should now be possible to use an ingress.hostname value of www.example.com and set the nginx.ingress.kubernetes.io/from-to-www-redirect annotation, without a TLS host for www.www.example.com being added.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Matteo Di Fazio <difaziomatteo@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 23, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 23, 2024
@github-actions github-actions bot removed the request for review from javsalgar September 23, 2024 07:26
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my suggestion

bitnami/drupal/templates/ingress.yaml Outdated Show resolved Hide resolved
EnDjeee and others added 2 commits September 29, 2024 11:44
Signed-off-by: Matteo Di Fazio <difaziomatteo@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@jotamartos jotamartos merged commit 1eca3e6 into bitnami:main Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drupal solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants