[bitnami/zookeeper] Expose appProtocol, scheme, and tlsConfig for Istio compatibility #29683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerod Culpepper <jcpepper@defenseunicorns.com>
Signed-off-by: Jerod Culpepper <jcpepper@defenseunicorns.com>
Signed-off-by: Jerod Culpepper <jcpepper@defenseunicorns.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
carrodher
added
verify
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
juan131
requested changes
Oct 3, 2024
Comment on lines
+24
to
+26
| {{- if .Values.metrics.service.appProtocol }} | ||
| appProtocol: {{ .Values.metrics.service.appProtocol }} | ||
| {{- end }} |
There was a problem hiding this comment.
Can't we simply rename the port name to http-metrics?
| @@ -28,4 +28,4 @@ maintainers: | |||
| name: zookeeper | |||
| sources: | |||
| - https://github.com/bitnami/charts/tree/main/bitnami/zookeeper | |||
| version: 13.4.14 | |||
| version: 13.4.15 | |||
There was a problem hiding this comment.
Please bump minor version instead given you're adding new chart parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Hi folks, this PR is to expose the
appProtocolfield for the metrics Service and theschemeandtlsConfigfields for the ServiceMonitor.Benefits
This will enable Prometheus metrics to be configured properly when deploying ZooKeeper to a cluster configured with Istio. The metrics service port name is
tcp-metricscausing Istio to automatically select the TCP protocol for this service which causes an error. By exposing theappProtocolfield we can override this selection with the correct protocol (in this case,http).Similarly for the ServiceMonitor object, exposing the
schemeandtlsConfigwill enable Prometheus metrics to be integrated with Istio.Possible drawbacks
I made the
appProtocol,scheme, andtlsConfigvalues optional and empty by default to ensure backwards compatibility.Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm