Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/airflow] Add support for setting a SQL connection string with existing databases #30417

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Nov 12, 2024

Description of the change

This PR adds support, when using an external database, to use a SQL connection string to indicate how to connect to it as an alternative to indicating host, port, db name, db user and db password.

Benefits

Users can customize the connection string for more complex scenarios (e.g. adding TLS connections).

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…h exiting databases

Signed-off-by: juan131 <jariza@vmware.com>
@github-actions github-actions bot added airflow verify Execute verification workflow for these changes bitnami labels Nov 12, 2024
bitnami-bot and others added 6 commits November 12, 2024 12:37
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
jotamartos previously approved these changes Nov 13, 2024
carrodher
carrodher previously approved these changes Nov 13, 2024
fmulero
fmulero previously approved these changes Nov 13, 2024
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I left a little comment

bitnami/airflow/templates/_helpers.tpl Outdated Show resolved Hide resolved
Signed-off-by: juan131 <jariza@vmware.com>
@juan131 juan131 dismissed stale reviews from fmulero, carrodher, and jotamartos via 23960a9 November 13, 2024 08:00
@juan131 juan131 enabled auto-merge (squash) November 13, 2024 08:01
@juan131 juan131 changed the title [bitnami/airflow] Add support for setting a SQL connection string with exiting databases [bitnami/airflow] Add support for setting a SQL connection string with existing databases Nov 13, 2024
@juan131 juan131 merged commit 6d994bd into bitnami:main Nov 13, 2024
13 checks passed
@juan131 juan131 deleted the feat/airflow-db-sql-conn branch November 13, 2024 08:28
rwilgaard pushed a commit to rwilgaard/bitnami-charts that referenced this pull request Nov 14, 2024
sajad-sadra pushed a commit to sajad-sadra/bitnami-charts that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants