[bitnami/contour] Add support for deploying GatewayClass and Gateway #30455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrodher
added
verify
rwilgaard
force-pushed
the
feature/contour-support-for-gateway-resources
branch
3 times, most recently
from
f9bb03e to
5b5986e
Compare
Signed-off-by: Rasmus Wilgaard <rasmus@wilgaard.dk>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
rwilgaard
force-pushed
the
feature/contour-support-for-gateway-resources
branch
from
5b5986e to
41a0c6a
Compare
|
Hi @rwilgaard thanks for creating this PR. Can we review it? I see you move it to draft status recently. Regards |
|
@fmulero This still needs some work. I will close this PR and open a new one when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is an extenstion of the #30166 PR that added the Gateway API CRDs to the chart. These changes adds support for deploying a GatewayClass and Gateway for Contour.
Benefits
It makes sense to be able to deploy the GatewayClass and Gateway in the same chart that deploys the CRDs and ingress controller.
Possible drawbacks
I don't see any.
Applicable issues
Additional information
Deployment of the GatewayClass and Gateway is disabled by default, so this doesn't change the current behavior of the chart.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm