Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/contour] Add ability to specify ingressClass and restart pods on config change #3367

Merged
merged 4 commits into from
Aug 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitnami/contour/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: contour
description: Contour Ingress controller for Kubernetes
version: 1.1.3
version: 1.2.0
appVersion: 1.7.0
keywords:
- ingress
Expand Down
13 changes: 12 additions & 1 deletion bitnami/contour/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,22 @@ The following tables lists the configurable parameters of the contour chart and
| `envoy.readynessProbe.timeoutSeconds` | When the probe times out | `1` |
| `envoy.readynessProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful after having failed. | `3` |
| `envoy.readynessProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed after having succeeded. | `1` |
| `envoy.service.type` | Type of envoy service to create | `LoadBalancer` |
| `envoy.service.externalTrafficPolicy` | If `envoy.service.type` is NodePort or LoadBalancer, set this to Local to enable [source IP preservation](https://kubernetes.io/docs/tutorials/services/source-ip/#source-ip-for-services-with-typenodeport) | `Local` |
| `envoy.service.clusterIP` | Internal envoy cluster service IP | `""` |
| `envoy.service.externalIPs` | Envoy service external IP addresses. | `[]` |
| `envoy.service.loadBalancerIP` | IP address to assign to load balancer (if supported) | `""` |
| `envoy.service.loadBalancerSourceRanges` | List of IP CIDRs allowed access to load balancer (if supported) | `[]` |
| `envoy.service.annotations` | Annotations for envoy service | `{}` |
| `envoy.service.ports.http` | Sets service http port | `80` |
| `envoy.service.ports.https` | Sets service https port | `443` |
| `envoy.service.nodePorts.http` | If `envoy.service.type` is NodePort and this is non-empty, it sets the nodePort that maps to envoys http port | `""` |
| `envoy.service.nodePorts.https` | If `envoy.service.type` is NodePort and this is non-empty, it sets the nodePort that maps to envoys https port | `""` |
| `existingConfigMap` | Specify an existing configMapName to use. (this mutually exclusive with existingConfigMap) | `nil` |
| `configInline` | Specify the config for contour as a new configMap inline. | `{Quickstart Config}` (evaluated as a template) |
| `ingressClass` | Name of the ingress class to route through this controller (defaults to `contour` if `nil`) | `nil` |
| `nameOverride` | String to partially override contour.fullname template with a string (will prepend the release name) | `nil` |
| `fullnameOverride` | String to fully override contour.fullname template with a string | `nil` |
| `rbac.create` | Specify if an rbac authorization should be created with the necessarry Rolebindings. | `true` |
| `prometheus.serviceMonitor.enabled` | Specify if a servicemonitor will be deployed for prometheus-operator. | `true` |
| `prometheus.serviceMonitor.jobLabel` | Specify the jobLabel to use for the prometheus-operator | `contour` |
| `prometheus.serviceMonitor.interval` | Specify the scrape interval if not specified use defaul prometheus scrapeIntervall | `""` |
Expand Down
7 changes: 7 additions & 0 deletions bitnami/contour/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ spec:
app.kubernetes.io/component: contour
template:
metadata:
{{- if .Values.configInline }}
annotations:
checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
{{- end }}
labels: {{- include "contour.labels" . | nindent 8 }}
app.kubernetes.io/component: contour
spec: {{- include "contour.imagePullSecrets" . | nindent 6 }}
Expand Down Expand Up @@ -57,6 +61,9 @@ spec:
- --contour-cert-file=/certs/tls.crt
- --contour-key-file=/certs/tls.key
- --config-path=/config/contour.yaml
{{- if .Values.ingressClass }}
- --ingress-class-name={{ .Values.ingressClass }}
{{- end }}
image: {{ include "contour.image" . }}
imagePullPolicy: {{ .Values.contour.image.pullPolicy }}
name: contour
Expand Down
8 changes: 8 additions & 0 deletions bitnami/contour/values-production.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ configInline:
# - "user_agent"
# - "x_forwarded_for"

## Name of the ingress class to route through this controller
##
# ingressClass: contour

## String to partially override contour.fullname include (will maintain the release name)
##
# nameOverride:
Expand Down Expand Up @@ -314,6 +318,10 @@ envoy:
##
type: LoadBalancer
externalTrafficPolicy: Local
# clusterIP: ""
# externalIPs: []
# loadBalancerIP: ""
# loadBalancerSourceRanges: []

## Service annotations
##
Expand Down
8 changes: 8 additions & 0 deletions bitnami/contour/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ configInline:
# - "user_agent"
# - "x_forwarded_for"

## Name of the ingress class to route through this controller
##
# ingressClass: contour

## String to partially override contour.fullname include (will maintain the release name)
##
# nameOverride:
Expand Down Expand Up @@ -309,6 +313,10 @@ envoy:
##
type: LoadBalancer
externalTrafficPolicy: Local
# clusterIP: ""
# externalIPs: []
# loadBalancerIP: ""
# loadBalancerSourceRanges: []

## Service annotations
##
Expand Down