Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/external-dns] Add value for controlling Google zone visibility #8278

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[bitnami/external-dns] Add value for controlling Google zone visibility #8278

merged 2 commits into from
Dec 9, 2021

Conversation

FalconerTC
Copy link
Contributor

@FalconerTC FalconerTC commented Nov 30, 2021 •
edited
Loading

Description of the change

Add Helm support for CloudDNS zone visibility filtering (added in kubernetes-sigs/external-dns#2153)

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/<name_of_the_chart>])

@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching bitnami/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

@FalconerTC FalconerTC changed the title Add value for controlling Google zone visibility [bitnami/external-dns] Add value for controlling Google zone visibility Nov 30, 2021
@FalconerTC
Copy link
Contributor Author

@miguelaeh Any chance for a review here?

javsalgar
javsalgar approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@javsalgar javsalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@javsalgar javsalgar merged commit 8188013 into bitnami:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javsalgar javsalgar javsalgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FalconerTC @javsalgar