Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odoo: replace longpolling_port with gevent_port #16855

Closed
wants to merge 1 commit into from

Conversation

amincheloh
Copy link

longpolling_port is deprecated in doo16 see https://github.com/odoo/odoo/blob/16.0/odoo/tools/config.py#L565

Signed-off-by: Amin Cheloh amincheloh@gmail.com

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

longpolling_port is deprecated in doo16 see https://github.com/odoo/odoo/blob/16.0/odoo/tools/config.py#L565

Signed-off-by: Amin Cheloh <amincheloh@gmail.com>

Signed-off-by: Amin Cheloh <amincheloh@gmail.com>
@github-actions github-actions bot added the odoo label Dec 13, 2022
@github-actions github-actions bot added the triage Triage is needed label Dec 13, 2022
@carrodher carrodher added the verify Execute verification workflow for these changes label Dec 14, 2022
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Dec 14, 2022
@bitnami-bot bitnami-bot removed the request for review from javsalgar December 14, 2022 07:48
@gongomgra
Copy link
Contributor

Hi @amincheloh,

Thanks for your contribution! Although your change is rather simple, we need to perform some further investigation on our side. I have opened an internal task to review it and our team will get back to you when they have any update. I'm moving this to on-hold in the meantime.

@github-actions github-actions bot added on-hold Issues or Pull Requests with this label will never be considered stale and removed in-progress labels Dec 15, 2022
@amincheloh
Copy link
Author

@gongomgra do you have any updates?

@gongomgra gongomgra removed the verify Execute verification workflow for these changes label Feb 6, 2023
@gongomgra
Copy link
Contributor

Hi @amincheloh,

I'm afraid our engineering team didn't have time to work on this yet, but they will post any update here once they do.

@1moere1
Copy link

1moere1 commented Apr 28, 2024

why is this still not merged? This issue still remains in v17

@gongomgra
Copy link
Contributor

Hi @1moere1,

Thanks for your interest in using Bitnami. I'm afraid we didn't have time to work on this on our side yet. I will ping the engineering team about this.

@gongomgra
Copy link
Contributor

Hi @amincheloh,

Thanks for your contribution and your interest in using Bitnami. Unfortunately, your change was not the only one required to fix this issue, and we have released a new image with many other generic changes required for this to work in all supported versions. You can find more information in the commit linked below

4a15baa

We are closing this PR now. Sorry for the inconveniences.

@gongomgra gongomgra closed this Jul 30, 2024
@github-actions github-actions bot removed the on-hold Issues or Pull Requests with this label will never be considered stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants