-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/odoo] Add ODOO_LIST_DB envvar, defaulting to False #67540
Conversation
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in the review of this PR. Could you please check my comment? Thank you for your contribution!!
bitnami/odoo/16/debian-12/rootfs/opt/bitnami/scripts/odoo/bitnami-templates/odoo.conf.tpl
Outdated
Show resolved
Hide resolved
no by default Thanks-To: Andrés Bono <andresbono@vmware.com> Signed-off-by: Didier 'OdyX' Raboud <didier.raboud@liip.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution! 🎉 Your changes will be included within the next release of the container.
Description of the change
Add an environment variable to be able to set
list_db = False
in the Odoo configuration file, defaulting to False, as per https://www.odoo.com/documentation/17.0/administration/on_premise/deploy.html?highlight=list_db%20no-database-list#securityBenefits
More "by-default" security, more configurability
Possible drawbacks
None
Applicable issues
Additional information
Happy to integrate any suggestions!