Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/odoo] Add ODOO_LIST_DB envvar, defaulting to False #67540

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

OdyX
Copy link
Contributor

@OdyX OdyX commented Jun 5, 2024

Description of the change

Add an environment variable to be able to set list_db = False in the Odoo configuration file, defaulting to False, as per https://www.odoo.com/documentation/17.0/administration/on_premise/deploy.html?highlight=list_db%20no-database-list#security

Benefits

More "by-default" security, more configurability

Possible drawbacks

None

Applicable issues

Additional information

Happy to integrate any suggestions!

@github-actions github-actions bot added odoo triage Triage is needed labels Jun 5, 2024
@github-actions github-actions bot requested a review from javsalgar June 5, 2024 07:14
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 5, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 5, 2024
@github-actions github-actions bot removed the request for review from javsalgar June 5, 2024 09:42
@github-actions github-actions bot requested a review from andresbono June 5, 2024 09:42
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jun 21, 2024
@OdyX
Copy link
Contributor Author

OdyX commented Jun 21, 2024

"this is recent activity".
Damn. I really dislike these auto-stalemate bots.

Copy link
Member

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the review of this PR. Could you please check my comment? Thank you for your contribution!!

no by default

Thanks-To: Andrés Bono <andresbono@vmware.com>
Signed-off-by: Didier 'OdyX' Raboud <didier.raboud@liip.ch>
Copy link
Member

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 🎉 Your changes will be included within the next release of the container.

@andresbono andresbono merged commit a969d1c into bitnami:main Jul 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odoo solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/odoo] Odoo should have list_db set to False (or --no-database-list)
4 participants