Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kubectl] Add yq #68007

Closed
wants to merge 1 commit into from
Closed

Conversation

snorwin
Copy link

@snorwin snorwin commented Jun 21, 2024

Description of the change

This PR adds yq to the kubectl container image. yq is a portable command-line YAML processor that enables users to manipulate YAML files, which is particularly useful for working with Kubernetes manifests.

Benefits

Enhances the functionality of the kubectl container image by adding the ability to easily manipulate YAML files.

Possible drawbacks

Increases the size of the container image (286MB -> 324MB) due to the addition of the yq binary and its dependencies.

Applicable issues

None

Additional information

There is also a light-weighted version of yq (https://github.com/mikefarah/yq) that could also be considered in order to get rid-off the python3 dependency.

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@github-actions github-actions bot added kubectl triage Triage is needed labels Jun 21, 2024
@github-actions github-actions bot requested a review from carrodher June 21, 2024 12:21
@github-actions github-actions bot removed the triage Triage is needed label Jun 24, 2024
@github-actions github-actions bot removed the request for review from carrodher June 24, 2024 16:08
@github-actions github-actions bot requested a review from migruiz4 June 24, 2024 16:08
@migruiz4
Copy link
Member

migruiz4 commented Jul 9, 2024

Thank you very much for your suggestion @snorwin!

After discussing it with the team, we have decided to accept this request and add 'yq' to the bitnami/kubectl container.

Although, I need to close this PR since the new dependency addition needs to be handled internally and will be sent in an automated PR separately.

@migruiz4 migruiz4 closed this Jul 9, 2024
@snorwin
Copy link
Author

snorwin commented Jul 9, 2024

@migruiz4 good to hear, thank you very much.

@migruiz4
Copy link
Member

migruiz4 commented Jul 9, 2024

@snorwin Here is the new release including 'yq': #69152 (bitnami/kubectl:1.28.11-debian-12-r5)

Please give it a try and let me know if it works for you

@snorwin
Copy link
Author

snorwin commented Jul 10, 2024

@migruiz4 looks good and works as expected, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants