[bitnami/phpmyadmin] fix wrong variables CONFIGURATION_ALLOWDENY_ #68068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
Signed-off-by: Nguyen Dang Trung Tien <trungtien238lnd@gmail.com>
tien238lnd
force-pushed
the
phpmyadmin/config_allowdeny
branch
from
0a23340
to
dc0eb81
Compare
carrodher
added
verify
jotamartos
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Rename 2 variables
ALLOWDENY_ORDERandALLOWDENY_RULES(I couldn’t find any previous declaration; it seems to be a variable name error) toCONFIGURATION_ALLOWDENY_ORDERandCONFIGURATION_ALLOWDENY_RULES.Benefits
The container can start with these variables, and it functions properly. The configuration was applied to the file
/opt/bitnami/phpmyadmin/config.inc.phpand works fine.Possible drawbacks
Not found yet.
Applicable issues