Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/pgbouncer] Add PGBOUNCER_APPLICATION_NAME_ADD_HOST #68126

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

rbojan
Copy link
Contributor

@rbojan rbojan commented Jun 27, 2024

Description of the change

Add PGBOUNCER_APPLICATION_NAME_ADD_HOST environment variable. See #68089

Benefits

PgBouncer setting application_name_add_host can be set through an environment variable.

Possible drawbacks

N/A

Applicable issues

Additional information

@github-actions github-actions bot added pgbouncer triage Triage is needed labels Jun 27, 2024
@github-actions github-actions bot requested a review from carrodher June 27, 2024 13:44
@rbojan rbojan changed the title Add PGBOUNCER_APPLICATION_NAME_ADD_HOST [bitnami/pgbouncer] Add PGBOUNCER_APPLICATION_NAME_ADD_HOST Jun 27, 2024
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Signed-off-by: Bojan Rogalo <bojan.rogalo@gmail.com>
@rbojan rbojan force-pushed the add-application-name-add-host branch from 6e7680d to 0c8e7cf Compare June 28, 2024 20:15
@rbojan
Copy link
Contributor Author

rbojan commented Jun 28, 2024

Thank you for reminding me that it is important to read the Contributing guidelines.

I force pushed my commit with my signature.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jul 1, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jul 1, 2024
@github-actions github-actions bot removed the request for review from carrodher July 1, 2024 06:17
@github-actions github-actions bot requested a review from juan131 July 1, 2024 06:17
@carrodher carrodher requested review from rafariossaa and removed request for juan131 July 1, 2024 06:36
@carrodher carrodher assigned rafariossaa and unassigned juan131 Jul 1, 2024
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this new environment variable to pgbouncer-env.sh

Signed-off-by: Bojan Rogalo <bojan.rogalo@gmail.com>
@rbojan
Copy link
Contributor Author

rbojan commented Jul 9, 2024

Added this new environment variable to pgbouncer-env.sh

@rbojan rbojan requested a review from rafariossaa July 9, 2024 08:33
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.
LGTM

@rafariossaa rafariossaa merged commit e184ce8 into bitnami:main Jul 9, 2024
11 checks passed
@rbojan rbojan deleted the add-application-name-add-host branch July 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pgbouncer solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants