[bitnami/postgresql] Updated libpostgresql.sh to specify a host to Postgres Commands #68236
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-mchugh
changed the title
…for psql commands Signed-off-by: James Riley McHugh <mchugh_james@bah.com>
james-mchugh
force-pushed
the
fix-postgresql-readiness-check
branch
from
16cd989
to
5095354
Compare
carrodher
added
verify
|
Thanks for taking the time to create this PR. Please let us test the changes and ensure this doesn't break the configuration of any solution in the catalog. Thanks |
jotamartos
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the
postgresql_start_bgandpostgresql_execute_print_outputfunctions in libpostgresql.sh to specify the loopback address as the host forpsqlandpg_isreadycommands.Benefits
If a custom unix socket directory is specified in the Primary configuration, startup will fail as the
psqlandpg_isreadycommands do not look at the correct location for the Unix socket directory. This updates them to use the loopback host which should work regardless of where the unix socket file is stored, and it is also consistent with the behavior of the probes used by the Helm chart.Being able to specify a custom Unix socket directory is useful, as the Bitnami Postgresql image provided by Iron Bank is built on top of the RHEL Universal Base Image and uses the RHEL Postgresql port. The RHEL Postgresql port defaults to storing Postgresql's unix socket under /run, which poses an issue as it is a common security measure to deploy containers with read-only root filesystems.
Possible drawbacks
None that I'm aware of. I've tested this in standalone and replication mode, and both appeared to work as expected.
Applicable issues
Additional information
There appears to be a separate bug here mentioned in #68027 where if the startup setup fails the first time, it will never be completed. When this happens, the Postgresql container will act as if it is healthy even though the authentication and databases have not been properly setup. This PR does not fix that issue.