Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Revert "[jjo] support Kubernetes v1.22+ apiVersions deprecations" #62

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

dbarranco
Copy link
Contributor

Reverts #61

It seems that #61 is going to cause some issues with our already existing Ingresses.
I've tested some new Ingresses in a 1.19 kops-based Kubernetes cluster and found-out the following:

....
[spec.rules[0].http.paths[0].backend: Invalid value: "": cannot set both port name & port number
And the Ingress resource I'm testing is:
...
  - host: <omitted>
    http:
      paths:
      - backend:
          service:
            name: <omitted>
            port:
              name: http
              number: 8080
        path: /
        pathType: ImplementationSpecific

Checking-out the official docs, it seems they also stopped adding the port number and name:

spec:
  rules:
  - http:
      paths:
      - path: /testpath
        pathType: Prefix
        backend:
          service:
            name: test
            port:
              number: 80

Ref.

cc/ @jjo

@dbarranco
Copy link
Contributor Author

@jjo I guess tomorrow we could do a sync about this and plan accordingly how we're going to address this issue.
Happy to help on this. I'm pushing this revert PR cause I wouldn't like to affect any of our production CD pipelines (they shouldn't be based in the latest commit of the libraries, but I prefer not take that risk now that we're at the end of our day)

@dbarranco dbarranco merged commit 93d0e65 into master Jun 16, 2021
@dbarranco dbarranco deleted the revert-61-jjo-fix-issue60-1.22-deprecations branch June 16, 2021 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants