Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrome and edge directories on windows #117

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix chrome and edge directories on windows #117

merged 2 commits into from
Oct 4, 2019

Conversation

cherifGsoul
Copy link
Contributor

Some fixes for windows:

  • Chrome directory and edge directory
  • Fix program files directory for x64 and x32 architectures, they were inverted:
//Windows 64bits "Program Files"
//Windows 32bits "Program Files x86"
var programFiles = os.arch() === "x64" ? process.env.ProgramFiles : process.env["ProgramFiles(x86)"];

Fixes #96

@cherifGsoul cherifGsoul mentioned this pull request Aug 26, 2019
Closed
@cherifGsoul cherifGsoul merged commit 64c45d6 into master Oct 4, 2019
@cherifGsoul cherifGsoul deleted the fix-chrome-edge-dirs branch October 4, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasenlehara chasenlehara Awaiting requested review from chasenlehara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cherifGsoul