This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
hasLowS validation not using correct constant as it is set in base 10 rather than hex #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbo
changed the title
|
ACK |
|
LGTM Looks like the bitcore-lib/lib/crypto/ecdsa.js Line 194 in 461852e |
braydonf
added a commit
that referenced
this pull request
Jan 21, 2016
hasLowS validation not using correct constant as it is set in base 10 rather than hex
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running this validation on test net and noticed even new transactions I was creating with the latest bitcoin client weren't validating correctly.
I've made the spec tests the boundaries of the low s/high s as well and cleaned it up a little there. Given BP62 is going more mainstream (more nodes running bitcoin 0.11.1 and 0.10.3) this might start to trip people up.