bump bn.js version to 5.1.3 in bitcore-lib #3484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkert
changed the title
|
Between package-lock.json and the other modules, I am sure more work would need to be done before this is ready for merge, so I've closed it out. However for my application, simply updating this one bitcore package did the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with the same update in elliptic (pending in indutny/elliptic#246, and indutny/elliptic#210) this fixes issue #3357
I assume this may possibly be needed in other areas of the monorepo since I see bn.js is used in other modules as well, but I have only tested this in bitcore-lib and only with the elliptic update linked above.