Fix Payment Protocol example in the browser #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanxcharles
pushed a commit
that referenced
this pull request
Aug 18, 2014
Fix Payment Protocol example in the browser
|
Ryan, please comment with test run results when merging, or if you didn't run them say the reason. This helps others while peer reviewing :) |
|
@maraoz, sorry, Ryan and I went over it together. The example was broken in the browser due to, I can only assume, changes in bitcore over time (I hadn't touched these examples in a while). I explained everything to Ryan and he ran the examples. Sorry he didn't post. |
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
Add 'User-Agent' header when sending requests to Insight
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
Fix Payment Protocol example in the browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in bitcore occured which broke the browser paypro example. Two hours of debugging later and I managed it fix it.