Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlike functionality #113

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

Unlike functionality #113

wants to merge 4 commits into from

Conversation

aishwarya-mustoori
Copy link
Contributor

What did you implement/accomplish in this pull request?
Give a short summary of what you completed in the pull request.

Backend Checklist

  • Tested edited/created routes
  • Make sure that all tests pass with flask test
  • Resolve all comments made
  • Remove any unecessary/commented code

Frontend Checklist

  • Tested that components can be flexible with different view formats (Desktop, tablet, mobile)
  • npm run build does not create any errors
  • Resolve all comments made
  • Remove any unecessary/commented code

@vercel
Copy link

vercel bot commented Jul 7, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bitproject/bit-next/4irxi86d1
✅ Preview: https://bit-next-git-aishwarya.bitproject.vercel.app

bryanwong8
bryanwong8 reviewed Jul 9, 2020
View reviewed changes
pages/article/[pid].tsx
@@ -73,10 +74,10 @@ border-radius: 22px;
const StyledEmoji2 = styled.div`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make heart emoji white not grey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is white not grey Bryan

bryanwong8
bryanwong8 reviewed Jul 9, 2020
View reviewed changes
components/global/ArticleCard.tsx
@@ -85,7 +78,7 @@ border-color: ${props => props.isPublished ? !props.bookmarked ?'#4EC700 !imp


/* article state: draft, review, pubished, complete*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing for the right side is way off. It looks like the image container has moved to the left side of the like bar when it should be above the title
Screen Shot 2020-07-09 at 11 06 32 AM (2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will check this out! I am not seeing this spacing in my laptop actually

bryanwong8
bryanwong8 reviewed Jul 9, 2020
View reviewed changes
pages/article/[pid].tsx
@@ -73,10 +74,10 @@ border-radius: 22px;
const StyledEmoji2 = styled.div`
background: red;
border-radius: 22px;
padding: 0.2em 0.4em 0.2em 0.4em;
padding: 0.5em;
margin :0.5em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emoji should have a hover click effect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a change i color on hover ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanwong8 bryanwong8 bryanwong8 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aishwarya-mustoori @bryanwong8