Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation release v1 #1012

Merged

Conversation

Titus-von-Koeller
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Feb 1, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada marked this pull request as draft February 2, 2024 06:01
Copy link
Collaborator

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the huge work @Titus-von-Koeller !
I left few comments, we should be almost there to merge this !
Please also see the tips regarding uploading images, writing proper docstring so that things will be compatible with HF-doc builder's auto-doc. Let's also not blow up the documentation with the introduction, a simple index page that redirects users to the correct page should be sufficient. See for example: https://github.com/huggingface/trl/blob/main/docs/source/index.mdx on how to use relative links between different doc pages.

bitsandbytes/nn/modules.py Outdated Show resolved Hide resolved
docs/source/resources.mdx Show resolved Hide resolved
@@ -27,6 +27,7 @@ dependencies:
- conda-forge::monkeytype # infer type annotations
- conda-forge::rich # better, colored tracebacks, etc
- conda-forge::pytest-sugar # better pytest output
# - conda-forge::nodejs # for `doc-builder preview` (optional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

docs/source/quickstart.mdx Show resolved Hide resolved
docs/source/optimizers.mdx Show resolved Hide resolved
docs/source/faqs.mdx Show resolved Hide resolved
docs/source/contributing.mdx Show resolved Hide resolved
Comment on lines 29 to 30
# - local: code_of_conduct
# title: Code of Conduct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - local: code_of_conduct
# title: Code of Conduct

docs/source/_toctree.yml Outdated Show resolved Hide resolved
bitsandbytes/nn/modules.py Show resolved Hide resolved
Copy link
Collaborator

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @Titus-von-Koeller ! 🚀 I left few final comments that you can directly apply through GH suggestions ! Let's 🚢 it once we confirm the Doc build is green after applying the suggestions !
Thanks again for putting all your hardwork on this !

.pre-commit-config.yaml Show resolved Hide resolved
README.md Show resolved Hide resolved
bitsandbytes/nn/modules.py Show resolved Hide resolved
docs/source/algorithms.mdx Outdated Show resolved Hide resolved
docs/source/compiling.mdx Show resolved Hide resolved
docs/source/integrations.mdx Outdated Show resolved Hide resolved
docs/source/integrations.mdx Outdated Show resolved Hide resolved
docs/source/integrations.mdx Outdated Show resolved Hide resolved
docs/source/integrations.mdx Show resolved Hide resolved
docs/source/integrations.mdx Outdated Show resolved Hide resolved
Titus-von-Koeller and others added 6 commits February 4, 2024 10:29
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
@Titus-von-Koeller Titus-von-Koeller marked this pull request as ready for review February 4, 2024 19:12
@Titus-von-Koeller Titus-von-Koeller merged commit acc7fb3 into bitsandbytes-foundation:main Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants