-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure bitsandbytes handles permission errors in the right order #622
Make sure bitsandbytes handles permission errors in the right order #622
Conversation
I just ran into this, I was about to open the same PR. I can confirm that @fozziethebeat's fix is correct. |
I can also confirm that this is the right fix, can this be merged soon? |
Hmm - this is my fix for the same problem: #715 Could ignoring permission errors mask legit errors? |
I've only had this problem on Google VMs, so your fix looks just as good to me. I figured since the code is already written this way, ordering it to work as intended should be fine. |
I doubt it, the goal of that function is to remove paths that cannot be used to find the CUDA libs anyway. |
I'm also running into the same error in my google VM. Are there plans to merge this fix? |
As far as I can tell, this repo has been frozen since early August. looks like this won't be getting merged anytime soon. |
This also fixes my issue on GCP. Will this be merged soon? |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
This definitely needs to be addressed. |
Sorry for the delay on this and thank you for your contribution! |
When trying to run bitsandbytes on GCP, I ran into an unexpected permission error during cuda driver lookup
I looked at the code and everything appeared correct until I discovered that
PermissionError
is a sub-type ofOSError
and thus the first except clause would catch any permission errors. This fixes that by swapping the except clauses.