chore: run image as node user #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop See merge request bitsensor/back-end/elastalert!35
Develop See merge request bitsensor/back-end/elastalert!36
jBouyoud
reviewed
May 13, 2019
Dockerfile
Outdated
| @@ -45,5 +45,12 @@ COPY config/config.json config/config.json | |||
| COPY rule_templates/ /opt/elastalert/rule_templates | |||
| COPY elastalert_modules/ /opt/elastalert/elastalert_modules | |||
|
|
|||
| # Add default rules directory | |||
| # Set permission as unpriviledged user (1000:1000), compatible with Kubernetes | |||
| RUN mkdir -p /opt/elastalert/rules/ \ | |||
There was a problem hiding this comment.
Test folder seems to be missing : /opt/elastalert/server_data/tests/
There was a problem hiding this comment.
Run elastalert image as unpriviledged user
|
Thank you for this merge request @jbdelpech 👍, it will be in the next beta release. |
|
This is available now in 3.0.0-beta.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run elastalert image as unpriviledged user, kubernetes compatible.
BTW, add a default empty dir in /opt/elastalert/rules.
If you have custom mounted volumes : it represents a BREAKING CHANGE for all images currently running as root in your cluster.
Before upgrading to this image : change your directory rights to 1000:1000 (or node:node into old elastalert image).
Feel free to test it, I packaged it from bitsensor/elastalert:2.0.1 with the changes of this PR :
solocal/elastalert:2.0.3Do not use it in production, this image will be removed soon.