Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra examples #54

Merged
merged 12 commits into from
Dec 23, 2022
Merged

Extra examples #54

merged 12 commits into from
Dec 23, 2022

Conversation

grctest
Copy link
Contributor

@grctest grctest commented Sep 19, 2022

Work in progress

Related to: bitshares/beet#207

@grctest grctest changed the base branch from master to develop September 19, 2022 23:18
Still needs valid operation parameters for all examples & manual functional testing
Several examples need 2nd evaluation: see 'todo debug'
@grctest
Copy link
Contributor Author

grctest commented Sep 21, 2022

Operations 32, 34, 36, 69 and 71 need a peer review, I wasn't sure what the input format was supposed to be like where marked // TODO: DEBUG

Also, should blank future extensions be included as extensions: [] or extensions: null?

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/bitshares/injections/069_credit_offer_create.js Outdated Show resolved Hide resolved
examples/bitshares/injections/071_credit_offer_update.js Outdated Show resolved Hide resolved
examples/bitshares/injections/071_credit_offer_update.js Outdated Show resolved Hide resolved
examples/bitshares/injections/074_credit_deal_expired.js Outdated Show resolved Hide resolved
examples/bitshares/injections/034_worker_create.js Outdated Show resolved Hide resolved
examples/bitshares/injections/036_assert.js Outdated Show resolved Hide resolved
@abitmore
Copy link
Member

Also, should blank future extensions be included as extensions: [] or extensions: null?

IIRC API nodes always accept extensions: [], and for some operations extensions: {}, but not always accept extensions: null.

@sschiessl-bcp
Copy link
Collaborator

sschiessl-bcp commented Nov 6, 2022

With the current beet rc I get stuck doing this

>> node ./bitshares/injections/001_limit_order_create.js 
received connected socket response
socket: authenticated
Connected to Beet
sending link request
sending linkRequest request
sending api request

No popup visible. Which Beet version / commit hash are you using?

@grctest
Copy link
Contributor Author

grctest commented Nov 24, 2022

@sschiessl-bcp Please use the following Beet PR: bitshares/beet#222

I've introduced several fixes to address the issue you ran into, including:

  • Tweaks to establishing blockchain connection when switching between blockchains BTS<->BTS_TEST
  • Timeouts have been introduced to several functions
  • More verbose error checks to reject erroneous injected parameters

I too wasn't getting the prompt, now I do get it in both production and testnet. If the prompt still doesn't show, try different asset ids etc?

@sschiessl-bcp
Copy link
Collaborator

see bitshares/beet#222

@sschiessl-bcp sschiessl-bcp merged commit 6ed2241 into bitshares:develop Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants