Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli_wallet caching issues #151

Open
1 of 3 tasks
vikramrajkumar opened this issue Jan 18, 2017 · 3 comments
Open
1 of 3 tasks

cli_wallet caching issues #151

vikramrajkumar opened this issue Jan 18, 2017 · 3 comments
Labels
4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform bug cli

Comments

@vikramrajkumar
Copy link
Contributor

vikramrajkumar commented Jan 18, 2017

From @theoreticalbts on January 21, 2016 20:44

The cache design of cli_wallet is fundamentally broken, leading to numerous issues: cryptonomex/graphene#323 cryptonomex/graphene#331 cryptonomex/graphene#353 cryptonomex/graphene#527

Anything which updates the account object causes a tendency for the cache to get out of sync. Really the CLI wallet should use the same architecture as the web wallet: Subscribe to object updates in order to implement a caching proxy for all object requests from individual wallet functions. As a stop-gap we could simply remove the existing cache, implement a new cache and require it to hit the witness_node anytime it needs an account (assuming most cli_wallet users also run witness_node on localhost or a fast LAN).

As this requires a substantial re-working of the wallet, perhaps this should be a worker proposal.

Copied from original issue: cryptonomex/graphene#530

Tasks to be done:

  • internal get_account function
  • list_my_accounts
  • account_id change when there is a fork (is this a separate issue?)
@vikramrajkumar
Copy link
Contributor Author

From @neura-sx on January 22, 2016 7:46

Maybe a simple resync() command would be a good temporary fix?
This command would force the CLI's cache to be reset.
Not perfect but it still better than having to start over the whole process.

aautushka pushed a commit to openledger/bitshares-core that referenced this issue Feb 2, 2018
@abitmore abitmore added the bug label Feb 5, 2018
@abitmore abitmore added the cli label Feb 5, 2018
@abitmore abitmore added this to the Next Non-Consensus-Changing Release milestone Feb 5, 2018
Clementvale added a commit to Clementvale-LTD/blockchain-telecom.graphene-core that referenced this issue Feb 6, 2018
cli_wallet caching issues bitshares#151
bitshares#151
taken from
openledger@4886364

Fix:
Capture exceptions when initializing `vote_id_type` with a string bitshares#578
bitshares#578
oxarbitrage added a commit that referenced this issue Feb 7, 2018
@abitmore abitmore modified the milestones: 201803 Non-Consensus-Changing Release, Future Non-Consensus-Changing Release Mar 4, 2018
@ryanRfox ryanRfox added the 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform label Feb 12, 2019
@ryanRfox
Copy link
Contributor

Assigning to @cogutvalera to review the original Issue(s), impacted code and draft a description of a proposed task list to seek approval for further development. The need on this Issue is to define what we want the fix to be and how we get there without breaking current functionality. Please be descriptive in your assessment and proposed solution options.

@cogutvalera
Copy link
Member

ok sure ! Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform bug cli
Projects
None yet
Development

No branches or pull requests

4 participants