Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential OpenSSL 1.1.1 linking issue #1791

Closed
3 tasks
abitmore opened this issue Jun 11, 2019 · 3 comments · Fixed by bitshares/bitshares-fc#139
Closed
3 tasks

Potential OpenSSL 1.1.1 linking issue #1791

abitmore opened this issue Jun 11, 2019 · 3 comments · Fixed by bitshares/bitshares-fc#139
Assignees
@pmconrad
Labels
2f Testing Status indicating the solution is being evaluated against the test case(s) 6 Build Impact flag identifying the build process
Milestone
3.2.0 - Feature R...

Comments

@abitmore
Copy link
Member

Build Error Description

FYI, Ubuntu 18.04 just bumped libssl-dev to openssl 1.1.1 which breaks linking with pthreads. Not sure if it breaks bitshares. If it does the fix is quite simple in FC's cmake. steemit/steem#3353

Figure I'd save you the trouble of digging through the internet to find the solution.

Thanks to @mvandeberg.

Build Environment

  • Host OS: Ubuntu 18.04 LTS
  • Host Physical RAM: [ ]
  • Source Branch/Tag: [ ]
  • OpenSSL Version: 1.1.1
  • Boost Version: [ ]
  • C++ Compiler: [ ]

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Provide build guidance
  • Create Bug Report
@abitmore abitmore added the 6 Build Impact flag identifying the build process label Jun 11, 2019
@abitmore abitmore added this to the 3.2.0 - Feature Release milestone Jun 11, 2019
@pmconrad
Copy link
Contributor

Thanks.
I see the same issue when building 3.1.0 for linux with gitian.
Changing library order in CMakeLists.txt as done in Steem seems to fix it for us as well.

Interestingly, the cross-build for windows is working with openssl-1.1.1c (current develop and fc PR 121).

pmconrad added a commit to pmconrad/fc that referenced this issue Jun 12, 2019
@pmconrad
Fixes bitshares/bitshares-core#1791
2e98d5c
@pmconrad pmconrad added the 2f Testing Status indicating the solution is being evaluated against the test case(s) label Jun 12, 2019
@pmconrad pmconrad self-assigned this Jun 12, 2019
@pmconrad pmconrad mentioned this issue Jun 12, 2019
Merged
abitmore added a commit to bitshares/bitshares-fc that referenced this issue Jun 12, 2019
@abitmore
Merge pull request #139 from pmconrad/1791_fix_linking_order
a87a99b 
Fixes bitshares/bitshares-core#1791
@abitmore
Copy link
Member Author

abitmore commented Jun 12, 2019 •
edited
Loading

Will close when bumped FC (perhaps in #1789 or #1792).

@abitmore abitmore reopened this Jun 12, 2019
@abitmore abitmore mentioned this issue Jun 13, 2019
Closed
@pmconrad
Copy link
Contributor

FC bumped in #1792

@pmconrad pmconrad mentioned this issue Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmconrad pmconrad

Labels
2f Testing Status indicating the solution is being evaluated against the test case(s) 6 Build Impact flag identifying the build process
Projects
None yet
Milestone
3.2.0 - Feature Release
Development

Successfully merging a pull request may close this issue.

Fixes https://github.com/bitshares/bitshares-core/issues/1791 pmconrad/fc
2 participants
@pmconrad @abitmore