Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process to Reset a SmartCoin after a Blackswan Event #216

Closed
vikramrajkumar opened this issue Jan 18, 2017 · 17 comments
Closed

Process to Reset a SmartCoin after a Blackswan Event #216

vikramrajkumar opened this issue Jan 18, 2017 · 17 comments

Comments

@vikramrajkumar
Copy link
Contributor

From @iperky on October 11, 2016 12:23

Is there a formal process to reset a SmartCoin after a blackswan event and divide the underlying collateral between the remaining SmartCoin holders?

I was under the impression that collateral would go into a settlement pool which holders can use to settle their remaining SmartCoins after this type of event.

ALTCAP.X has blackswaned and has five holders who I would like to make whole by returning the underlying bitBTC collateral.

Copied from original issue: cryptonomex/graphene#664

@vikramrajkumar
Copy link
Contributor Author

From @xeroc on October 11, 2016 12:49

ALTCAP.X has blackswaned and has six holders who I would like to make whole by returning the underlying bitBTC collateral.

That should be possible by simply requesting a "settlement".

@vikramrajkumar
Copy link
Contributor Author

From @iperky on October 11, 2016 14:37

SmartCoin holders see the following using the gui

Failed to broadcast the transaction:
Cannot force settle with no price feed.

and in the cli

0 exception: unspecified
37006 insufficient_feeds: insufficient feeds
Cannot force settle with no price feed.

I cannot publish a price feed due to the blackswan.

Is global_settle_asset useful in this situation?

@vikramrajkumar
Copy link
Contributor Author

From @pmconrad on October 11, 2016 19:10

That looks like a bug.
No, global_settle_asset won't help you there.

@vikramrajkumar
Copy link
Contributor Author

From @iperky on October 13, 2016 17:9

Thanks for your replies xeroc and pmconrad.

I have been using the test-net to settle smartcoins after a blackswan.

ALTCAP.X, SETTLE and SETTLE.WEEK have now all been force settled due to lack of collateral on the test net. In doing this, I have found FEED LIFETIME IN MINUTES to be very important in allowing holders to settle their smartcoins.

SETTLE.WEEK was created with a FEED LIFETIME of 10080 minutes (one week) to test settlement of the asset for up to one week after a blackswan. I will post later if this works as planned.

A 24 hour feed lifetime is insufficient time to allow holders to settle and recover collateral. I apologize to the ALTCAP.X holders for not testing this setting thoroughly and hope ALTCAP.X can be reset in the future to allow holders to recover their funds.

In light of this, I have changed FEED LIFETIME to 10080 minutes for ALTCAP on the bitshares network and recommend the committee increases FEED LIFETIME on all bitASSET smartcoins.

@vikramrajkumar
Copy link
Contributor Author

From @grctest on October 14, 2016 15:29

Relevant bitsharestalk thread: https://bitsharestalk.org/index.php/topic,23334.0.html

The GRIDCOIN MPA (in blackswan state) doesn't have the 'Force Settlement' option (gave up said permission).

@vikramrajkumar
Copy link
Contributor Author

From @pmconrad on October 14, 2016 15:43

The GRIDCOIN MPA (in blackswan state) doesn't have the 'Force Settlement' option (gave up said permission).

That doesn't matter. After a black swan, forced settlement is allowed in any case. https://github.com/cryptonomex/graphene/blob/master/libraries/chain/asset_evaluator.cpp#L436

FEED_LIFETIME shouldn't matter, because after a black swan settlement doesn't happen at the feed price but at the (fixed) settlement_price. That is a bug that needs fixing. Should be allowed here but isn't: https://github.com/cryptonomex/graphene/blob/master/libraries/chain/asset_evaluator.cpp#L439

@vikramrajkumar
Copy link
Contributor Author

From @iperky on October 16, 2016 16:21

Yes "FEED_LIFETIME shouldn't matter" but it does at the minute.
Now on bitshares and the test-net you have only the "FEED_LIFETIME" to settle your smartcoins after a blackswan.

The test I mentioned above:
SETTLE - I cannot settle because the 24 hour FEED_LIFETIME has passed
SETTLE.WEEK can still be settled because FEED_LIFETIME is 10080 minutes (1 week)

@vikramrajkumar
Copy link
Contributor Author

From @abitmore on October 30, 2016 0:29

FEED_LIFETIME shouldn't matter, because after a black swan settlement doesn't happen at the feed price but at the (fixed) settlement_price. That is a bug that needs fixing. Should be allowed here but isn't: https://github.com/cryptonomex/graphene/blob/master/libraries/chain/asset_evaluator.cpp#L439

The code

   else if( bitasset.current_feed.settlement_price.is_null() )
      FC_THROW_EXCEPTION(insufficient_feeds, "Cannot force settle with no price feed.");

perhaps should be

   else if( bitasset.current_feed.settlement_price.is_null() || bitasset.has_settlement())
      FC_THROW_EXCEPTION(insufficient_feeds, "Cannot force settle with no price feed.");

so an asset not in black swain state shouldn't be forced settled if no enough price feed provided.

Thoughts?

@vikramrajkumar
Copy link
Contributor Author

From @pmconrad on October 30, 2016 13:37

Close... I think this would be the correct condition:

else if( bitasset.current_feed.settlement_price.is_null() && !bitasset.has_settlement())

i. e. throw an error if neither feed nor settlement are available. Settlement is possible with either feed or settlement.

@ghost
Copy link

ghost commented Jan 26, 2017

Please reset ALTCAP.X also.

NASDAQ, Hang Seng, Shenzhen Composite and Nikkei - Market Indexes also need their precision increased.

@xeroc
Copy link
Member

xeroc commented Jan 26, 2017

@pmconrad knows more about the bug that prevents settling without valid feeds .. he mentioned something here
https://github.com/bitshares/bsips/blob/master/bsip-0017.md

@testzcrypto
Copy link

Please check BitRUB and reset if needed.

@xanoxt
Copy link

xanoxt commented Mar 19, 2017

Hello.

Please reset BitRUB, that would allow us to proceed with our gateway business bringing Russians to the bitshares DEX. So, if it can be done soon, that would be awesome, because we'll be able to bring more people and liquidity to the DEX. Thanks!

@grctest
Copy link

grctest commented Apr 30, 2017

What's the current progress with this issue? BSIP-0017 lists it still as a draft.

@abitmore
Copy link
Member

abitmore commented May 1, 2017

No progress, I guess. Last activity in the forum post is several months ago.

@pmconrad
Copy link
Contributor

pmconrad commented May 3, 2017

I have started writing some test cases, but that's about it.

I don't think anyone is seriously working on it at this time.

@pmconrad pmconrad mentioned this issue Jul 29, 2017
@oxarbitrage oxarbitrage modified the milestones: Roadmap to hardfork, BSIP 018, Roadmap to hardfork 1 Aug 13, 2017
oxarbitrage pushed a commit that referenced this issue Sep 6, 2017
@oxarbitrage
Copy link
Member

please note this is fixed in #340 and we now have a formal process to revive blackswan that is available in the testnet now for testing and will be soon part of the next release. hardfork was needed to make this work and it is backed up by a BSIP(https://github.com/bitshares/bsips/blob/master/bsip-0018.md) and a worker proposal(http://www.bitshares.foundation/workers/2017-07-peter-conrad) approved by the shareholders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants