Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The es_test often fails when running in Github Actions #2283

Closed
1 of 17 tasks
abitmore opened this issue Oct 7, 2020 · 4 comments · Fixed by #2371 or #2373
Closed
1 of 17 tasks

The es_test often fails when running in Github Actions #2283

abitmore opened this issue Oct 7, 2020 · 4 comments · Fixed by #2371 or #2373
Labels
testing
Milestone
5.2.0 - Feature R...

Comments

@abitmore
Copy link
Member

abitmore commented Oct 7, 2020 •
edited
Loading

Bug Description

The Github Autobuild process sometimes fails on es_test. It is caused by the shared ES service among multiple CI jobs.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other: testing

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the Future Feature Release milestone Oct 7, 2020
@abitmore abitmore mentioned this issue Mar 5, 2021
Merged
@abitmore abitmore linked a pull request Mar 5, 2021 that will close this issue
Randomize index prefixes in ES tests #2371
Merged
@abitmore
Copy link
Member Author

abitmore commented Mar 6, 2021

Fixed by #2371.

@abitmore abitmore closed this as completed Mar 6, 2021
@abitmore abitmore mentioned this issue Mar 6, 2021
Merged
@abitmore
Copy link
Member Author

abitmore commented Mar 6, 2021

Not fixed. See #2373.

@abitmore abitmore reopened this Mar 6, 2021
@abitmore abitmore linked a pull request Mar 6, 2021 that will close this issue
Fix Github Actions es_test failing issue #2373
Merged
@abitmore abitmore removed this from the 5.2.0 - Feature Release milestone Mar 6, 2021
@abitmore abitmore changed the title Github Autobuild: ES service is shared among multiple CI jobs thus causes errors The es_test often fails when running in Github Actions Mar 6, 2021
@abitmore abitmore added this to the 5.2.0 - Feature Release milestone Mar 6, 2021
@abitmore
Copy link
Member Author

abitmore commented Mar 6, 2021

It seems it's not a concurrency issue. Perhaps it's just because the ES docker service is slow sometimes.

@abitmore
Copy link
Member Author

abitmore commented Mar 6, 2021

Fixed by #2371 and #2373.

@abitmore abitmore closed this as completed Mar 6, 2021
@abitmore abitmore mentioned this issue Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
5.2.0 - Feature Release
1 participant
@abitmore