Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions es_test failing issue #2373

Merged
merged 11 commits into from
Mar 6, 2021
Merged

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Mar 6, 2021

Follow-up of #2371.

Slightly refactor es_test and other unit tests.

Fixes #2283.

@abitmore abitmore added this to the 5.2.0 - Feature Release milestone Mar 6, 2021
@abitmore abitmore force-pushed the fix-es-test-concurrency branch from fe4a0e6 to 75c8833 Compare March 6, 2021 02:25
@abitmore abitmore linked an issue Mar 6, 2021 that may be closed by this pull request
17 tasks
Move the init_unit_test_suite(...) function to a hpp file and
include it in every unit test app:
- app_test
- chain_test
- cli_test
- es_test
- performance_test
@abitmore abitmore force-pushed the fix-es-test-concurrency branch from 75c8833 to 44345ce Compare March 6, 2021 02:44
@abitmore abitmore changed the title Init unit test suite for all unit test apps Fix Github Actions es_test failing issue Mar 6, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abitmore abitmore merged commit 9fb62c4 into develop Mar 6, 2021
@abitmore abitmore deleted the fix-es-test-concurrency branch March 6, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The es_test often fails when running in Github Actions
1 participant